Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Income Tax Computation): consideration of new employees without preexisting salary slips #2197

Merged

Conversation

krantheman
Copy link
Member

While generating the Income Tax Computation report, if an employee does not have pre-existing salary slips, the system looks for salary structure assignments on or before the selected Payroll Period start date. But an employee might not have a salary structure assignment till from when they joined, which could be after the aforementioned Payroll Period start date. In such a case, the system throws an error.

This PR fixes this by looking for assignments on or before the date of joining for such employees.

@krantheman krantheman merged commit 72e55ce into frappe:develop Sep 18, 2024
8 checks passed
@krantheman krantheman deleted the fix-income-tax-computation-report branch September 18, 2024 07:22
krantheman added a commit that referenced this pull request Sep 18, 2024
…2197

fix(Income Tax Computation): consideration of new employees without preexisting salary slips (backport #2197)
krantheman added a commit that referenced this pull request Sep 18, 2024
…2197

fix(Income Tax Computation): consideration of new employees without preexisting salary slips (backport #2197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant